ref: make PR comment workflow generic #89460
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
jianyuan
force-pushed
the
ref/make-pr_comment-workflow-generic
branch
2 times, most recently
from
e026de5 to
a9510b4
Compare
jianyuan
force-pushed
the
ref/make-pr_comment-workflow-generic
branch
2 times, most recently
from
96dd30e to
aab80f2
Compare
cathteng
reviewed
Apr 14, 2025
Comment on lines
+1026
to
+1087
| def run_pr_comment_workflow(integration_name: str, pullrequest_id: int, project_id: int) -> None: | ||
| cache_key = debounce_pr_comment_cache_key(pullrequest_id=pullrequest_id) | ||
|
|
||
| try: | ||
| pr = PullRequest.objects.get(id=pullrequest_id) | ||
| assert isinstance(pr, PullRequest) | ||
| except PullRequest.DoesNotExist: | ||
| cache.delete(cache_key) | ||
| logger.info(_pr_comment_log(integration_name=integration_name, suffix="pr_missing")) | ||
| return | ||
|
|
||
| try: | ||
| organization = Organization.objects.get_from_cache(id=pr.organization_id) | ||
| assert isinstance(organization, Organization) | ||
| except Organization.DoesNotExist: | ||
| cache.delete(cache_key) | ||
| logger.info(_pr_comment_log(integration_name=integration_name, suffix="org_missing")) | ||
| metrics.incr( | ||
| MERGED_PR_METRICS_BASE.format(integration=integration_name, key="error"), | ||
| tags={"type": "missing_org"}, | ||
| ) | ||
| return | ||
|
|
||
| try: | ||
| repo = Repository.objects.get(id=pr.repository_id) | ||
| assert isinstance(repo, Repository) | ||
| except Repository.DoesNotExist: | ||
| cache.delete(cache_key) | ||
| logger.info( | ||
| _pr_comment_log(integration_name=integration_name, suffix="repo_missing"), | ||
| extra={"organization_id": organization.id}, | ||
| ) | ||
| metrics.incr( | ||
| MERGED_PR_METRICS_BASE.format(integration=integration_name, key="error"), | ||
| tags={"type": "missing_repo"}, | ||
| ) | ||
| return | ||
|
|
||
| integration = integration_service.get_integration( | ||
| integration_id=repo.integration_id, status=ObjectStatus.ACTIVE | ||
| ) | ||
| if not integration: | ||
| cache.delete(cache_key) | ||
| logger.info( | ||
| _pr_comment_log(integration_name=integration_name, suffix="integration_missing"), | ||
| extra={"organization_id": organization.id}, | ||
| ) | ||
| metrics.incr( | ||
| MERGED_PR_METRICS_BASE.format(integration=integration_name, key="error"), | ||
| tags={"type": "missing_integration"}, | ||
| ) | ||
| return | ||
|
|
||
| installation = integration.get_installation(organization_id=organization.id) | ||
| assert isinstance(installation, CommitContextIntegration) | ||
|
|
||
| installation.run_pr_comment_workflow( | ||
| organization=organization, | ||
| repo=repo, | ||
| pr=pr, | ||
| project_id=project_id, | ||
| ) |
There was a problem hiding this comment.
i think it's okay to move this into the original task instead of moving it into a function and calling it anyway
jianyuan
force-pushed
the
ref/make-pr_comment-workflow-generic
branch
from
50dfcf3 to
9681243
Compare
…enames_from_source_file
jianyuan
force-pushed
the
ref/make-pr_comment-workflow-generic
branch
from
9681243 to
636110d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHubIntegrationand generic methods toCommitContextIntegration.get_pullrequest_filesan abstract method ofCommitContextClient.source_code_management.